Lending protocol - ongoing work and bug fixes - XLS-66 #6102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Originally defined as uint64_t, but the testIssuerLoan() test called it with a negative number, causing an overflow to a very large number that in some circumstances could be silently cast back to an int64_t, but might not be. I believe this is UB, and we don't want to rely on that.
7 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ximinez/lending-XLS-66-2 #6102 +/- ##
========================================================
Coverage 79.1% 79.1%
========================================================
Files 839 839
Lines 71402 71380 -22
Branches 8325 8318 -7
========================================================
- Hits 56477 56476 -1
+ Misses 14925 14904 -21
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
- Adds additional unit tests to cover math calculations. - Removes unused methods.
…minez/lending-XLS-66-ongoing * XRPLF/ximinez/lending-XLS-66-2: Change some instances of View info() to header() Update rippled to xrpl refactor: Rename `ripple` namespace to `xrpl` (5982) refactor: Move JobQueue and related classes into xrpl.core module (6121) refactor: Rename `rippled` binary to `xrpld` (5983) refactor: rename info() to header() (6138) refactor: rename `LedgerInfo` to `LedgerHeader` (6136) refactor: clean up `RPCHelpers` (5684) chore: Fix docs readme and cmake (6122) chore: Clean up .gitignore and .gitattributes (6001) chore: Use updated secp256k1 recipe (6118)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR continues the work started in #5270 and #6093. All new code changes that affect Lending should be done in this branch. That includes PRs.
Implement the Lending Protocol as described in XLS-66
Context of Change
Type of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)