Set up fees for WASM processing #5393
Merged
+342
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ripple/smart-escrow #5393 +/- ##
=====================================================
Coverage ? 78.1%
=====================================================
Files ? 794
Lines ? 68495
Branches ? 8303
=====================================================
Hits ? 53502
Misses ? 14993
Partials ? 0
🚀 New features to boost your workflow:
|
sappenin
reviewed
Apr 9, 2025
sappenin
reviewed
Apr 9, 2025
oleks-rip
reviewed
Apr 9, 2025
| @@ -37,6 +37,7 @@ struct Fees | |||
| std::uint32_t extensionComputeLimit{ | |||
| 0}; // Extension compute limit (instructions) | |||
| std::uint32_t extensionSizeLimit{0}; // Extension size limit (bytes) | |||
| std::uint32_t gasPrice{0}; // price of WASM gas (micro-drops) | |||
There was a problem hiding this comment.
All these names doesn't show any relations among them. Consider to give them some common root / field of usage, for example
extensionSizeLimit-> contractSizeLimit
extensionComputeLimit -> contractGasLimit
gasPrice -> contractGasPrice
ComputationAllowance -> contractGasPayment
sfFinishFunction -> sfContract
tefNO_WASM -> tefNO_CONTRACT
and so on
There was a problem hiding this comment.
Extensions != contracts, so that's an incorrect statement. More specifically, we may want different values for extensions vs contracts further down the line.
There was a problem hiding this comment.
What "extension" is refer to? And as we have gasPrice, which is definitely used with contracts, not extensions, so it just bring more ambiguity.
There was a problem hiding this comment.
pwang200
approved these changes
Apr 11, 2025
oleks-rip
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR:
gasPrice- this is the price of 1 gas in micro-drops (i.e. 1,000,000 of this unit = 1 drop/gas)EscrowFinishparameter,ComputationAllowance- this is how much gas the transaction submitter is willing to payComputationAllowance * gasPrice / 100000to theEscrowFinishtransaction feeContext of Change
Setting up proper fees for WASM usage
Type of Change
Test Plan
Tests were added and work properly.