Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Asset Vault #5224

Open
wants to merge 122 commits into
base: develop
Choose a base branch
from

Simplify conversions to Json::Value

241429b
Select commit
Loading
Failed to load commit list.
Open

Single Asset Vault #5224

Simplify conversions to Json::Value
241429b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 18, 2024 in 1s

77.9% (target 60.0%)

View this Pull Request on Codecov

77.9% (target 60.0%)

Details

Codecov Report

Attention: Patch coverage is 75.19873% with 156 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (49e0d54) to head (241429b).

Files with missing lines Patch % Lines
src/xrpld/ledger/detail/View.cpp 69.4% 41 Missing ⚠️
src/xrpld/app/tx/detail/VaultDelete.cpp 31.8% 30 Missing ⚠️
src/xrpld/app/tx/detail/VaultClawback.cpp 70.8% 14 Missing ⚠️
src/xrpld/app/tx/detail/VaultDeposit.cpp 77.8% 12 Missing ⚠️
src/xrpld/app/tx/detail/VaultWithdraw.cpp 70.7% 12 Missing ⚠️
src/xrpld/app/tx/detail/VaultCreate.cpp 87.5% 9 Missing ⚠️
src/libxrpl/protocol/STNumber.cpp 77.1% 8 Missing ⚠️
src/xrpld/app/tx/detail/VaultSet.cpp 80.0% 6 Missing ⚠️
src/xrpld/app/tx/detail/MPTokenAuthorize.cpp 78.9% 4 Missing ⚠️
src/xrpld/app/tx/detail/MPTokenIssuanceDestroy.cpp 77.8% 4 Missing ⚠️
... and 7 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5224     +/-   ##
=========================================
- Coverage     77.9%   77.9%   -0.0%     
=========================================
  Files          783     795     +12     
  Lines        66707   67202    +495     
  Branches      8140    8179     +39     
=========================================
+ Hits         51964   52317    +353     
- Misses       14743   14885    +142
Files with missing lines Coverage Δ
include/xrpl/json/json_value.h 98.5% <ø> (ø)
include/xrpl/protocol/AMMCore.h 100.0% <ø> (ø)
include/xrpl/protocol/Asset.h 95.2% <100.0%> (+0.5%) ⬆️
include/xrpl/protocol/Feature.h 100.0% <ø> (ø)
include/xrpl/protocol/IOUAmount.h 100.0% <ø> (ø)
include/xrpl/protocol/Indexes.h 100.0% <100.0%> (ø)
include/xrpl/protocol/MPTAmount.h 100.0% <ø> (ø)
include/xrpl/protocol/MPTIssue.h 100.0% <100.0%> (ø)
include/xrpl/protocol/SField.h 100.0% <ø> (ø)
include/xrpl/protocol/STAmount.h 95.4% <100.0%> (+0.3%) ⬆️
... and 44 more

... and 8 files with indirect coverage changes

Impacted file tree graph

View more details on Codecov