781: handle None from fullmatch reference regex - #782
Merged
Conversation
- this code branch is for `is_pyxform_reference` but it didn't handle the case where there is no match - in which case the iteration over `outer_matches` would fail and throw an error like "None has no group" - added test coverage for relevant usages of is_pyxform_reference: - repeat_count, now with tests showing common usage pattern outcomes - seed param, which had alternate usages already (constant/single ref)
lognaturel
reviewed
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #781
Why is this the best possible solution? Were any other approaches considered?
is_pyxform_referencebut it didn't handle the case where there is no match (looks like reference but has other characters) - in which case the iteration overouter_matcheswould fail and throw an error like "None has no group"What are the regression risks?
Fixes a regression, and tries to avoid others of a similar nature by adding more tests.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No
Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code