Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

None invalid address parameter; Broadcast address invalid for RemoteValue and Device #1401

Merged
merged 7 commits into from
Feb 5, 2024

Conversation

farmio
Copy link
Member

@farmio farmio commented Feb 5, 2024

Description

  • None in a RemoteValue or Device group address list is now ignored instead of parsed as broadcast address.
  • Broadcast address ("0/0/0") is now invalid for RemoteValue and Device group addresses and raises CouldNotParseAddress.
  • None is not a valid address parameter for GroupAddress and IndividualAddress anymore. It raises CouldNotParseAddress.
  • Added message to CouldNotParseAddress for more information about why it was raised.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The documentation has been adjusted accordingly
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog (docs/changelog.md)

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd1b613) 96.61% compared to head (b567515) 96.61%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1401   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files         151      151           
  Lines        9772     9778    +6     
=======================================
+ Hits         9441     9447    +6     
  Misses        331      331           
Files Coverage Δ
xknx/devices/binary_sensor.py 98.91% <ø> (ø)
xknx/devices/climate.py 100.00% <ø> (ø)
xknx/devices/climate_mode.py 100.00% <ø> (ø)
xknx/devices/cover.py 99.46% <ø> (ø)
xknx/devices/datetime.py 100.00% <ø> (ø)
xknx/devices/expose_sensor.py 100.00% <ø> (ø)
xknx/devices/fan.py 100.00% <ø> (ø)
xknx/devices/light.py 99.60% <ø> (ø)
xknx/devices/notification.py 100.00% <ø> (ø)
xknx/devices/numeric_value.py 100.00% <ø> (ø)
... and 23 more

@farmio farmio merged commit fb12550 into main Feb 5, 2024
11 checks passed
@farmio farmio deleted the handle-none-ga branch February 5, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant