Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff isort plugin instead of isort #1353

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Use ruff isort plugin instead of isort #1353

merged 3 commits into from
Nov 5, 2023

Conversation

farmio
Copy link
Member

@farmio farmio commented Nov 5, 2023

Description

  • Use ruff isort plugin instead of isort
  • Move ruff to separate tox env (so dependabot updates can trigger a run - which doesn't work for update pre-commit hooks script)
  • Run ruff in pre-commit only on pre-commit
  • Remove isort from requirements
  • Remove black target_version as it is now inferred from project.requires-python
  • Only run tests for specified python version, only lint in one CI runner

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The documentation has been adjusted accordingly
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog (docs/changelog.md)

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #1353 (544d0a0) into main (a51e2b4) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1353      +/-   ##
==========================================
+ Coverage   96.55%   96.56%   +0.01%     
==========================================
  Files         150      150              
  Lines        9584     9584              
==========================================
+ Hits         9254     9255       +1     
+ Misses        330      329       -1     

see 1 file with indirect coverage changes

@farmio farmio merged commit 9e8ea4d into main Nov 5, 2023
10 checks passed
@farmio farmio deleted the ruff-isort branch November 5, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant