make sure that release build is the default again#387
Open
irmen wants to merge 1 commit into
Open
Conversation
…ptimizations are enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so -O3 compiler optimizations are enabled again. Otherwise a non optimizing default/debug build is being made.
Without this, it is reported that the emulator is unusable on some systems (such as RPi 400)
Also it fixes the performance of the normal x86 desktop build. On my system it used to warp at 800-900% but has now been stuck at 250-300% since the switch to cmake.
note the ci builds fail not because of this particular PR but because there is a problem in the github action related to the pdf docs, this is fixed in #389