-
Notifications
You must be signed in to change notification settings - Fork 60
Added documentation for the fill command in debugger #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also an additional, optional "incr/step" parameter, specifying how much the address should increment between each consecutive write. Default is 1, as for the N number of bytes.
By the way, is there a reason for using
" "instead of" "here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I is to ensure it does not create a linebreak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working with HTML, I have seen the code
used before (without properly understanding its purpose until reading up on the topic now). It makes perfect sense to add a nbsp character, although the source code may become less readable.I am not sure what is used elsewhere in the documentation (if it is used at all). But, could the code
instead of perhaps give the reader of the source code some better insight what this is, compared to a magic number?At least now I know this is intentional, and that it serves a particular purpose. Always nice to learn something new!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know that we have a standard here, and I don't have strong feelings going either way, so I'm inclined to approve this as-is. If someone with a vested interest wants to hold a conversation or contradict me, feel free to do so. Heck, I'll even volunteer to swap the characters here myself, if necessary.