Draw call batching for Paths #81
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EMaksymenko
reviewed
Oct 14, 2024
.../src/commonMain/kotlin/earth/worldwind/shape/milstd2525/AbstractMilStd2525TacticalGraphic.kt
Outdated
Show resolved
Hide resolved
EMaksymenko
reviewed
Oct 14, 2024
.../src/commonMain/kotlin/earth/worldwind/shape/milstd2525/AbstractMilStd2525TacticalGraphic.kt
Outdated
Show resolved
Hide resolved
EMaksymenko
reviewed
Oct 14, 2024
EMaksymenko
reviewed
Oct 14, 2024
EMaksymenko
reviewed
Oct 14, 2024
EMaksymenko
reviewed
Oct 14, 2024
worldwind/src/commonMain/kotlin/earth/worldwind/layer/RenderableLayer.kt
Outdated
Show resolved
Hide resolved
EMaksymenko
reviewed
Oct 14, 2024
worldwind/src/commonMain/kotlin/earth/worldwind/layer/RenderableLayer.kt
Outdated
Show resolved
Hide resolved
EMaksymenko
reviewed
Oct 14, 2024
worldwind/src/commonMain/kotlin/earth/worldwind/layer/RenderableLayer.kt
Outdated
Show resolved
Hide resolved
EMaksymenko
reviewed
Oct 14, 2024
worldwind/src/commonMain/kotlin/earth/worldwind/layer/RenderableLayer.kt
Outdated
Show resolved
Hide resolved
EMaksymenko
reviewed
Oct 14, 2024
EMaksymenko
reviewed
Oct 14, 2024
worldwind/src/commonMain/kotlin/earth/worldwind/render/VertexState.kt
Outdated
Show resolved
Hide resolved
EMaksymenko
reviewed
Oct 14, 2024
| open class TriangleShaderProgram : AbstractShaderProgram() { | ||
| override var programSources = arrayOf( | ||
| """ | ||
| #version 300 es |
Member
There was a problem hiding this comment.
Should we add ES 3.0 declaration in Android manifest also? Or we already have it there?
Contributor
Author
There was a problem hiding this comment.
just use it for this file. We will need to rewrite all other shaders if this will be added to manifest, probably should be done in separate pr if ever
EMaksymenko
reviewed
Oct 14, 2024
| var maximumIntermediatePoints = 10 | ||
| protected lateinit var activeAttributes: ShapeAttributes | ||
| protected var isSurfaceShape = false | ||
| lateinit var activeAttributes: ShapeAttributes |
Member
There was a problem hiding this comment.
Do we still need to have it public?
Contributor
Author
There was a problem hiding this comment.
Yes, still used in PathSet to get attributes
EMaksymenko
reviewed
Oct 14, 2024
| protected var isSurfaceShape = false | ||
| lateinit var activeAttributes: ShapeAttributes | ||
| protected set | ||
| var isSurfaceShape = false |
Member
There was a problem hiding this comment.
Smae here. Do we still need to hava it public?
Contributor
Author
There was a problem hiding this comment.
Yes, still used in PathSet to get attributes
EMaksymenko
reviewed
Oct 14, 2024
| var lastRequestedFrameIndex = 0L | ||
|
|
||
| open fun addToBatch(rc : RenderContext) : Boolean { | ||
| return rc.currentLayer is RenderableLayer && allowBatching && !isHighlighted |
Member
There was a problem hiding this comment.
In case of Graticule it will not b a renderable layer. Can we remove this cast check?
Contributor
Author
There was a problem hiding this comment.
Added TODO comment, better to address that in another PR with more testing
EMaksymenko
requested changes
Oct 14, 2024
Member
EMaksymenko
left a comment
EMaksymenko
left a comment
There was a problem hiding this comment.
Please review my comments.
EMaksymenko
force-pushed
the
develop
branch
5 times, most recently
from
5811728 to
cfa9e03
Compare
IOTRFAFH
force-pushed
the
lines_batching_attempt
branch
3 times, most recently
from
dde82c9 to
f2e153a
Compare
EMaksymenko
force-pushed
the
develop
branch
2 times, most recently
from
4bfbf07 to
eeaba99
Compare
IOTRFAFH
force-pushed
the
lines_batching_attempt
branch
3 times, most recently
from
90542bd to
a8af57c
Compare
EMaksymenko
force-pushed
the
develop
branch
5 times, most recently
from
c5c8815 to
c28aed6
Compare
EMaksymenko
force-pushed
the
develop
branch
11 times, most recently
from
0bf3c5c to
093d2e8
Compare
EMaksymenko
force-pushed
the
develop
branch
3 times, most recently
from
eaf9fef to
66dbbe8
Compare
EMaksymenko
force-pushed
the
develop
branch
3 times, most recently
from
addc715 to
d8bd268
Compare
EMaksymenko
force-pushed
the
develop
branch
6 times, most recently
from
af5af3d to
b82af69
Compare
EMaksymenko
force-pushed
the
develop
branch
2 times, most recently
from
0c0b8bd to
ddf6b9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.