Merged
Conversation
Contributor
Author
|
https://github.com/MelvinShwuaner/ModLoader/wiki/Custom-Sound-System |
Collaborator
|
I just took a look at this and was wondering about two things:
|
Contributor
Author
the item asset creator doesnt work as an issue had shown, and i thought it would be weird for 2 utilities to do the same thing. |
Contributor
Author
Contributor
Author
|
Still have to fix localizatin |
here ive added asset file loading, and ive also made linking assets much easier with master builders, you add builders to the master then buildall to build them and link their assets. this is also important for asset file loading,because of delegates! delegates cant be serialized, so i had to create a SerializableAsset class, this stores the variables along with the delegates info, and then once mod assemblies are loaded, the assets are loaded
Contributor
Author
|
fixed it all |
made it so custom sounds can also be used as drawing sounds
this is so you can set all of the variables in just your constructor
inmny
reviewed
May 21, 2025
inmny
reviewed
May 26, 2025
inmny
approved these changes
May 26, 2025
Contributor
inmny
left a comment
There was a problem hiding this comment.
the methods in old ItemAssetCreator are just made for telling modder what parameters are useful for such kind of item.
Contributor
Author
Okay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




ive been playing around with the custom sound system and noticed that 3d sounds are alot more quiet then normal sounds, and the only way to fix this is to add custom sounds to the in-game sound bank which is practically impossible.
so instead i turned 3d into a soundmode, you have basic (2d), stereo 3d (the original 3D) and mono 3d which doesn't use FMOD's 3D system but instead just changes volume over distance, this allows for loud sounds.
ive also implemented Builders!!!!! these are supposed to help modders create things, like tabs, assets, etc. ive only added a few but ive built the Architecture, i hope someone like tuxxego will build on it! i will also be building on it in the future