Skip to content

feat: add support for Apple embedded platforms (iOS, tvOS, watchOS, visionOS) #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hayashi-mas-wap merged 4 commits into from
Jan 7, 2026
Merged

feat: add support for Apple embedded platforms (iOS, tvOS, watchOS, visionOS) #308

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd8e6a1
feat: add support for Apple embedded platforms (iOS, tvOS, watchOS, v…
h1431532403240 Dec 25, 2025
8e26e91
Update sudachi/src/plugin/loader.rs
h1431532403240 Jan 5, 2026
38d586b
refactor: change make_system_specific_name to return Option<String>
h1431532403240 Jan 5, 2026
637d8ff
fix: format code with rustfmt
h1431532403240 Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sudachi/src/plugin/loader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@ fn make_system_specific_name(s: &str) -> String {
format!("lib{}.dylib", s)
}

#[cfg(any(target_os = "ios", target_os = "tvos", target_os = "watchos", target_os = "visionos"))]
fn make_system_specific_name(_s: &str) -> String {
Copy link
Contributor

@hayashi-mas-wap hayashi-mas-wap Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will let fn system_specific_name return a path to a directory and it may cause a problem.
I want you to change the signature of make_system_specific_name to fn (&str) -> Option<String> and let the variable fname (in l.80) to be None in those target OSs.

String::new()
}

fn system_specific_name(s: &str) -> Option<String> {
if s.contains('.') {
None
Expand Down