Fix Tracer.startSpan signature #216
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyggalt
requested review from
blakeroberts-wk and
evanweible-wf
as code owners
| List<api.Attribute> attributes = const [], | ||
| List<api.SpanLink> links = const [], | ||
| Int64? startTime, | ||
| bool newRoot = false}); |
There was a problem hiding this comment.
This is a breaking change that would require bumping the minor version. If we want this change, we'll want to clean up the other breaking changes that should be contained within the next minor version release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Inconsistency between implementation (SDK) and interface (API) of
Tracer.startSpan.Short description of the change
Ensures that the API's
Tracer.startSpansignature matches that in the implementation.How Has This Been Tested?
Running all tests again with the change made.
Checklist:
(I don't think either is relevant, but happy to discuss)