feat: Promote Expandable and add codemod to handle change #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
expandable-promotion-25-03
|
| Run status |
|
| Run duration | 02m 43s |
| Commit |
|
| Committer | Josh |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
936
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
21.41%
|
|
|---|---|
|
Untested elements
|
1521
|
|
Tested elements
|
412
|
Accessibility
99.28%
|
|
|---|---|
|
Failed rules
|
6 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
98
|
josh-bagwell
changed the title
josh-bagwell
changed the title
NicholasBoll
approved these changes
Apr 2, 2025
NicholasBoll
added
automerge
and removed
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #3106
This PR promotes the
Expandablecomponent from Labs to Main. It also adds a codemod to update the imports.Release Category
Components
Release Note
Promotion of the
Expandablecomponent from Labs to Main.BREAKING CHANGES
The
Expandablecomponent has been promoted fromLabstoMain. There is a codemod to handle the update of the imports.Where Should the Reviewer Start?
/modules/react/expandable/modules/codemod/lib/v13/promoteExpandable.ts/modules/codemod/lib/v13/spec/promoteExpandable.spec.ts