-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refactor Pill component to use new styling utilities and tokens #3104
Merged
alanbsmith
merged 63 commits into
Workday:prerelease/major
from
mannycarrera4:mc-refactor-pills
Mar 17, 2025
Merged
feat: Refactor Pill component to use new styling utilities and tokens #3104
alanbsmith
merged 63 commits into
Workday:prerelease/major
from
mannycarrera4:mc-refactor-pills
Mar 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workday/canvas-kit
|
Project |
Workday/canvas-kit
|
Branch Review |
mc-refactor-pills
|
Run status |
|
Run duration | 02m 46s |
Commit |
|
Committer | Manuel Carrera |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
2
|
|
21
|
|
0
|
|
936
|
View all changes introduced in this branch ↗︎ |
UI Coverage
21.31%
|
|
---|---|
|
1530
|
|
412
|
Accessibility
99.27%
|
|
---|---|
|
6 critical
5 serious
0 moderate
2 minor
|
|
98
|
mannycarrera4
commented
Jan 27, 2025
mannycarrera4
commented
Jan 27, 2025
mannycarrera4
commented
Jan 27, 2025
Co-authored-by: Josh <[email protected]>
Co-authored-by: Josh <[email protected]>
Co-authored-by: Josh <[email protected]>
Co-authored-by: Josh <[email protected]>
Co-authored-by: Josh <[email protected]>
Co-authored-by: Josh <[email protected]>
Co-authored-by: Josh <[email protected]>
josh-bagwell
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2394, #2968, #2049
Release Category
Components
Release Note
We've updated ExternalHyperlink to use our new styling utilities and tokens.
licorice400
tolicorice500
to match our design specs.maxWidth
is set, it is set on the parent<Pill/>
element and the child elements will be styled accordingly. Before v13,maxWidth
wasn't calculating the width of all its elements and wasn't a true pixel value.BREAKING CHANGES
maxWidth
has been removed from theusePillModel
. This config was used to style sub components. With the refactor to usedata-part
and stencils, it is no longer needed on the model. You can still applymaxWidth
on the parent<Pill>
element and the child elements will be styled accordingly.Pill.Icon
no longer has a defaultaria-labe="add"
. You must provide anaria-label
forPill.Icon
to ensure proper accessibility. Our examples have been updated to reflect this change.Pill.IconButton
no longer has a defaultaria-label="remove"
. You must provide anaria-label
forPill.IconButton
to ensure proper accessibility. Our examples have been updated to reflect this change.Pill.Label
is a required element when using other sub components likePill.Icon
to ensure that the label truncates correctly.Checklist
ready for review
has been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)