Skip to content

Simple FTPext stub#8622

Closed
SirLouen wants to merge 1 commit intoWordPress:trunkfrom
SirLouen:patch/63201
Closed

Simple FTPext stub#8622
SirLouen wants to merge 1 commit intoWordPress:trunkfrom
SirLouen:patch/63201

Conversation

@SirLouen
Copy link
Copy Markdown
Member

A simple patch to fix a disturbing type error for stubs

Trac ticket: https://core.trac.wordpress.org/ticket/63201


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sirlouen.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

/**
* @since 2.5.0
* @var resource
* @var FTP\Connection|resource
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added false as well in r61116

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 3, 2025

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61116
GitHub commit: 7c6c07f

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants