-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Editor: sync latest packages to trunk #10551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
One failure seems due to WordPress/gutenberg@efb328b, maybe the snapshots need to be updated in trunk. |
The PR changed the exports from the @wordpress/interactivity package. It removed the `debug` WordPress export module completely. This requires some changes to the special way the debug script module was being registered. See WordPress/gutenberg#72485.
The debug module was removed, only the main interactivity module is exposed.
|
I've pushed two commits to backport necessary changes from WordPress/gutenberg#72485. These were required because the There was some special handling in place for its debug module that had to be removed. @youknowriad it would be great if you could take a look at the backports I've added to this PR. |
| * - interactivity/index.min.js or interactivity/index.js => @wordpress/interactivity | ||
| * - block-library/query/view.min.js or block-library/query/view.js => @wordpress/block-library/query/view | ||
| */ | ||
| $script_module_id = '@wordpress/' . preg_replace( '~(?:/index)?(?:\.min)?\.js$~D', '', $file_name, 1 ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WordPress/gutenberg#72485 changed this line which I did not copy, as far as I can tell the change is not significant: https://github.com/WordPress/gutenberg/pull/72485/files#r2560447901
Maybe it should be updated just for the sake of consistency:
| $script_module_id = '@wordpress/' . preg_replace( '~(?:/index)?(?:\.min)?\.js$~D', '', $file_name, 1 ); | |
| $script_module_id = '@wordpress/' . preg_replace( '~(?:/index)?\.(min\.)?js$~D', '', $file_name, 1 ); |
|
There's a remaining failure unrelated to Interactivity or Modules: |
|
The categories class change appears to be from WordPress/gutenberg#72662. The categories block --- 1/index.php
+++ 2/index.php
@@ -79,7 +79,7 @@ function render_block_core_categories( $attributes, $content, $block ) {
}
}
- $wrapper_attributes = get_block_wrapper_attributes( array( 'class' => "wp-block-categories-{$type}" ) );
+ $wrapper_attributes = get_block_wrapper_attributes( array( 'class' => "wp-block-categories-{$type} wp-block-categories-taxonomy-{$attributes['taxonomy']}" ) );
return sprintf(
$wrapper_markup,I'll push a commit to update the failing test assertion. FYI @ntsekouras. |
Gutenberg PR 72662 updated the rendering of the categories block adding this class. See WordPress/gutenberg#72662.
Thanks. That sounds fine! |
|
Currently the editors are not loading:
|
Trac ticket: https://core.trac.wordpress.org/ticket/64303
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.