Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wp-env: Add --skip-confirmation option to destroy command #68787

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

jrmd
Copy link

@jrmd jrmd commented Jan 20, 2025

What?

This patch adds support for wp-env destroy --skip-confirmation which allows for the command to be ran without the blocking confirmation prompt.

Why?

Running this command in a script requires confirmation from stdin, adding the skip confirmation option allows us to bypass this limitation allows script writers to run then cleanup without issue.

How?

PR adds an optional argument to the destroy command which is used to skip over the confirmation prompt to assume yes.

Testing Instructions

  1. run wp-env destroy --skip-confirmation
  2. see the confirmation isn't shown and the environment is destroyed as expected
  3. run wp-env destroy
  4. see the confirmation prompt is shown and works as previous

This patch adds support for `wp-env destroy --skip-confirmation` which
allows for the command to be ran without the blocking confirmation
prompt. Which easily allows this to be ran within scripts and on CI.
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jrmd <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 20, 2025
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jrmd! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Tool] Env /packages/env labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Tool] Env /packages/env [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants