Fix: Prevent FontSizePicker
crash when no font size exists
#68733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #62072
What?
This PR fixes a crash in the Typography panel's font size picker when no font size presets exist in theme.json. It ensures that the font size picker is disabled when no presets are available and prevents errors when setting a custom font size.
Why?
Currently, if a theme has defaultFontSizes set to false and no font size presets are defined, changing the font size causes the block to crash due to
fontSizeValue?.startsWith
being called on an invalid type. This PR resolves the issue by ensuring fontSizeValue is always a valid string before performing operations on it.How?
Added a check to ensure fontSizeValue is a string before calling
.startsWith()
.Testing Instructions
Code snippet for theme.json
Screenshots or screencast
Before
Screen.Recording.2025-01-17.at.12.09.29.PM.mov
After
Screen.Recording.2025-01-17.at.12.10.47.PM.mov