Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing classNames on global-styles ToolsPanels #68478

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

0verscore
Copy link

@0verscore 0verscore commented Jan 3, 2025

What?

This PR introduces classNames for the border, dimensions, and background ToolsPanel components located in packages/block-editor/src/components/global-styles

Why?

A unique selector is required to eg. embed a portal within these components. The necessary classes have already been implemented and are also in use within block components.

Impact?

These changes will not result in any visible differences in the interface. If needed, I can further refine the classNames for better differentiation in the global-styles context.

Let me know if you’d like additional adjustments!

Before After
screenshot-before screenshot-after

@0verscore 0verscore requested a review from ellatrix as a code owner January 3, 2025 10:09
Copy link

github-actions bot commented Jan 3, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Jan 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: 0verscore <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Jan 3, 2025

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @0verscore! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant