Tabs: Remove unnecessary stories #68463
Conversation
mirka
added
[Type] Developer Documentation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| @@ -367,133 +366,3 @@ const CloseButtonTemplate: StoryFn< typeof Tabs > = ( props ) => { | |||
| ); | |||
| }; | |||
| export const InsertCustomElements = CloseButtonTemplate.bind( {} ); | |||
|
|
|||
| const ControlledModeTemplate: StoryFn< typeof Tabs > = ( props ) => { | |||
There was a problem hiding this comment.
Controlled mode is explained better on the Best Practices page. Behavior should/can be covered in the unit tests.
| selectedTabId: 'tab3', | ||
| }; | ||
|
|
||
| const TabBecomesDisabledTemplate: StoryFn< typeof Tabs > = ( props ) => { |
There was a problem hiding this comment.
Behavior should/can be covered in the unit tests.
| }; | ||
| export const TabBecomesDisabled = TabBecomesDisabledTemplate.bind( {} ); | ||
|
|
||
| const TabGetsRemovedTemplate: StoryFn< typeof Tabs > = ( props ) => { |
There was a problem hiding this comment.
Behavior should/can be covered in the unit tests.
|
Flaky tests detected in eeab286. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12582426057
|
My wording was a bit ambiguous 🙈 I meant that the unit tests already cover them. |
Prerequisite for #68329
What?
Removes unnecessary Storybook stories for the
Tabscomponent:Why?
Every story should have value to our audience, because each story adds noise and maintenance cost.
The "Size And Overflow Playground" story is basically a test fixture and should also eventually be removed or at least suppressed from the Storybook. I am leaving it for now because I assume these overflow features are still somewhat under development (cc @ciampo).
Testing Instructions
See Storybook for
Tabs.