Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Submenu: Add Border and Spacing support #68455

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

dhruvikpatel18
Copy link
Contributor

@dhruvikpatel18 dhruvikpatel18 commented Jan 2, 2025

What?

Add border and spacing block support to the Navigation Submenu block.

Why?

Navigation Submenu block is missing border and spacing support.
Part of #43247
Part of #43243

How?

Adds the border and spacing block support in block.json

Testing Instructions

  • Go to Global Styles Settings. ( Under Appearance > Editor > Styles > Edit styles > Blocks )
  • Ensure the Navigation Submenu block’s border and spacing are configurable via Global Styles.
  • Confirm Global Styles apply correctly in both the Editor and Frontend.
  • Open the Page or Template where you want to add the menu.
  • Add a Navigation block (the container block for all navigation links and Submenus).
  • Within the Navigation block, add Submenu block.
  • Verify Border, Radius, and Spacing settings are available for this Submenu block.
  • Check that block-specific styles (e.g., borders, spacing) take precedence over Global Styles.
  • Ensure borders and spacing display correctly in both the Editor and Frontend.

Screenshots or screencast

Submenu.block.mov

@dhruvikpatel18 dhruvikpatel18 marked this pull request as ready for review January 3, 2025 05:46
Copy link

github-actions bot commented Jan 3, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Jan 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @[email protected].

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: [email protected].

Co-authored-by: dhruvikpatel18 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant