-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed publish word to publish date #68437
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @deborah86. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Thanks for the pull request; this has been a minor pet peeve of mine and has confused some of my coworkers who only work with gutenberg as a content editor. As mentioned in the original issue #41319 - using publish multiple times is confusing. I support this change. Notably, the nearby aria-label for both instance states 'change publish date'
cc'ing @afercia because I think you were working (and advocating for) for issues like these a while back. I fear that this PR will end up being buried because it's not made by a core contributor :/ |
Personally I'd be in favor of the proposed change because as mentioned in the related issue 'Publish' 1) it's unclear 2) there's a clear inconsistency between verbs and names. Some care should be taken with translations that may provide longer strings. For example, the correct translation in Italian would be 'Data di pubblicazione' which would go in two lines. Same would happen with many other languages. At the very least the vertical alignment should take into account the increased height when the text wraps in two lines. Screenshot: |
I think this PR is also related to #63342. One concern is mentioned in this comment:
In other words, is the following display acceptable? Post sidebar: Pre-publish panel (If this panel is expected to improve as well): |
Checking in from editorial—would |
As per @provenself suggestion, I’ve updated the wording. Please have a look at the screenshots and share any additional suggestions for improvement. If it looks good, I will update the same in next commit. |
I have concerns about the latest proposal to use 'Publish Time'. First, 'time' is an ambiguous term in English because, depending on context, it can be time or hour. Likely, it would be confusing for translators and I'm not sure it's the best term in the first place. I'd like to suggest to ping the Polyglots team to get some feedback. For example, in my native language (Italian), it could be translated in two ways:
I'm pretty sure it would be confusing to translate in many other languages as well. Also, it would be too long. In many languages, this string would o in two lines when translated, which isn't ideal. Example screenshot: Overall, with a little bit of lateral thinking, I have the impression we're all trying to cure the symptom rather than the real cause. The post summary panel two columns layout isn't ideal for long labels in the first place. Instead of trying to shorten the content and make it 'fit' in the design, we should acknowledge the design doesn't solve a functional problem in thefirst place. The 'publish date and time' setting is, in a way, special as it needs to communicate as clearly as possible complex concepts like 'publish now', or publish to a past date, or schedule etc. Personally, I also think this setting should pe more prominent and separated from the other post properties. To me, the fact ths discussion on this PR struggles to identify the best option for this string proves that the design itself isn't ideal. I il further comment on the issue #41319 |
What?
Fixes: #41319
Why?
The word "Publish" is not descriptive as to what the option modifies. It should give the user a clear indication of what will be changed or modified.
How?
Changed publish word to publish date in sidebar and also in modal.
Testing Instructions
Screenshots or screencast