Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed publish word to publish date #68437

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

benazeer-ben
Copy link
Contributor

What?

Fixes: #41319

Why?

The word "Publish" is not descriptive as to what the option modifies. It should give the user a clear indication of what will be changed or modified.

How?

Changed publish word to publish date in sidebar and also in modal.

Testing Instructions

  1. Open a post or page.
  2. Publish the page.
  3. Check publish details in sidebar and verify.

Screenshots or screencast

Before After
Screenshot (12)Screenshot (13) Screenshot (10)Screenshot (14)

Copy link

github-actions bot commented Dec 31, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @deborah86.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: deborah86.

Co-authored-by: benazeer-ben <[email protected]>
Co-authored-by: skorasaurus <[email protected]>
Co-authored-by: afercia <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: provenself <[email protected]>
Co-authored-by: kristastevens <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@skorasaurus skorasaurus added the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Dec 31, 2024
@skorasaurus
Copy link
Member

skorasaurus commented Dec 31, 2024

Thanks for the pull request; this has been a minor pet peeve of mine and has confused some of my coworkers who only work with gutenberg as a content editor.

As mentioned in the original issue #41319 - using publish multiple times is confusing. I support this change.

Notably, the nearby aria-label for both instance states 'change publish date'

'aria-label': __( 'Change publish date' ),
&

cc'ing @afercia because I think you were working (and advocating for) for issues like these a while back.

I fear that this PR will end up being buried because it's not made by a core contributor :/

@afercia afercia added the [Type] Enhancement A suggestion for improvement. label Jan 2, 2025
@afercia
Copy link
Contributor

afercia commented Jan 2, 2025

Personally I'd be in favor of the proposed change because as mentioned in the related issue 'Publish' 1) it's unclear 2) there's a clear inconsistency between verbs and names.

Some care should be taken with translations that may provide longer strings. For example, the correct translation in Italian would be 'Data di pubblicazione' which would go in two lines. Same would happen with many other languages. At the very least the vertical alignment should take into account the increased height when the text wraps in two lines. Screenshot:

Screenshot 2025-01-02 at 12 06 05

@t-hamano
Copy link
Contributor

t-hamano commented Jan 3, 2025

I think this PR is also related to #63342.

One concern is mentioned in this comment:

The default date/time value when creating a new post is Immediately, which is likely the reason why this visual label was changed to Publish. The new wording should complement well with Immediately.

In other words, is the following display acceptable?

Post sidebar:

399947862-4b57a066-43f3-4184-974d-b3e62a83732e

Pre-publish panel (If this panel is expected to improve as well):

399948953-e6b2ce69-738e-44e5-93e9-89d143e01531

@afercia
Copy link
Contributor

afercia commented Jan 3, 2025

Related: I think I've mentioned in another issue or PR (couldn't find it any longer) that the term Immediately should be reconsidered, also because in the publish date popover it's called Now. Which is inconsistent and likely a good way to confuse users. Screenshot:

Screenshot 2025-01-03 at 15 58 13

@provenself
Copy link

Checking in from editorial—would Publish time be a more flexible option? That would match up more nicely with now or immediately, while also allowing for full adjustment.

@benazeer-ben
Copy link
Contributor Author

As per @provenself suggestion, I’ve updated the wording. Please have a look at the screenshots and share any additional suggestions for improvement.

Screenshot (1)
Screenshot (2)
Screenshot (3)

If it looks good, I will update the same in next commit.

@afercia
Copy link
Contributor

afercia commented Jan 9, 2025

I have concerns about the latest proposal to use 'Publish Time'.

First, 'time' is an ambiguous term in English because, depending on context, it can be time or hour. Likely, it would be confusing for translators and I'm not sure it's the best term in the first place. I'd like to suggest to ping the Polyglots team to get some feedback. For example, in my native language (Italian), it could be translated in two ways:

  • Tempo di pubblicazione
  • Ora di pubblicazione

I'm pretty sure it would be confusing to translate in many other languages as well.

Also, it would be too long. In many languages, this string would o in two lines when translated, which isn't ideal. Example screenshot:

Screenshot 2025-01-09 at 09 15 17

Overall, with a little bit of lateral thinking, I have the impression we're all trying to cure the symptom rather than the real cause. The post summary panel two columns layout isn't ideal for long labels in the first place. Instead of trying to shorten the content and make it 'fit' in the design, we should acknowledge the design doesn't solve a functional problem in thefirst place. The 'publish date and time' setting is, in a way, special as it needs to communicate as clearly as possible complex concepts like 'publish now', or publish to a past date, or schedule etc.

Personally, I also think this setting should pe more prominent and separated from the other post properties. To me, the fact ths discussion on this PR struggles to identify the best option for this string proves that the design itself isn't ideal. I il further comment on the issue #41319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Copy Review Needs review of user-facing copy (language, phrasing) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "Publish" to "Publish Date"
5 participants