Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoryBook: Add Story for ResolutionTool #68292

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

im3dabasia
Copy link
Contributor

Part of #67165

What?

This PR adds Storybook stories for the ResolutionTool component to improve component documentation and testability.

Testing Instructions

  1. Run npm run storybook:dev
  2. Open Storybook at http://localhost:50240/
  3. Verify the following stories are present and functioning:
  4. Default rendering of the ResolutionTool component.

Screenshots or screencast

Screen.Recording.2024-12-25.at.4.43.47.PM.mov

@im3dabasia im3dabasia marked this pull request as ready for review December 26, 2024 16:20
@im3dabasia im3dabasia requested a review from ellatrix as a code owner December 26, 2024 16:20
Copy link

github-actions bot commented Dec 26, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@im3dabasia im3dabasia force-pushed the storybook/resolution-control branch from d15debe to 17c114a Compare December 26, 2024 16:38
@im3dabasia
Copy link
Contributor Author

Hey @t-hamano ,

Please review my PR when you have a moment and provide me with your feedback.

@t-hamano
Copy link
Contributor

@im3dabasia Thanks for the PR.

I recently made some changes to the Storybook structure which seems to be causing a conflict. Could you resolve this conflict first?

@t-hamano t-hamano added [Type] Developer Documentation Documentation for developers Storybook Storybook and its stories for components labels Dec 28, 2024
@im3dabasia im3dabasia force-pushed the storybook/resolution-control branch from 17c114a to 59590d4 Compare December 30, 2024 11:29
@im3dabasia
Copy link
Contributor Author

im3dabasia commented Dec 30, 2024

@im3dabasia Thanks for the PR.

I recently made some changes to the Storybook structure which seems to be causing a conflict. Could you resolve this conflict first?

Done please check @t-hamano

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

It looks like there have been some big changes to the default story component, is there a reason for this? I think the story should work mostly as is and this PR just needs to improve the meta object.

@im3dabasia
Copy link
Contributor Author

I think the story should work mostly as is and this PR just needs to improve the meta object.

Thank you for the feedback; I appreciate it.

I will revert to the old stories code and then work on improving the meta object in the old story. I will also take into consideration the current feedback provided for the meta object.

@im3dabasia im3dabasia requested a review from t-hamano January 3, 2025 13:15
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano
Copy link
Contributor

t-hamano commented Jan 4, 2025

Note: One E2E test is failing, but not due to this PR. The E2E test failure should be resolved in #68484.

@t-hamano t-hamano merged commit 50d2e06 into WordPress:trunk Jan 4, 2025
62 of 63 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.1 milestone Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants