-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StoryBook: Add Story for ResolutionTool #68292
StoryBook: Add Story for ResolutionTool #68292
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
d15debe
to
17c114a
Compare
Hey @t-hamano , Please review my PR when you have a moment and provide me with your feedback. |
@im3dabasia Thanks for the PR. I recently made some changes to the Storybook structure which seems to be causing a conflict. Could you resolve this conflict first? |
17c114a
to
59590d4
Compare
Done please check @t-hamano |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
It looks like there have been some big changes to the default story component, is there a reason for this? I think the story should work mostly as is and this PR just needs to improve the meta
object.
packages/block-editor/src/components/resolution-tool/stories/index.story.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/resolution-tool/stories/index.story.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/resolution-tool/stories/index.story.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/resolution-tool/stories/index.story.js
Outdated
Show resolved
Hide resolved
Thank you for the feedback; I appreciate it. I will revert to the old stories code and then work on improving the meta object in the old story. I will also take into consideration the current feedback provided for the meta object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Note: One E2E test is failing, but not due to this PR. The E2E test failure should be resolved in #68484. |
Part of #67165
What?
This PR adds Storybook stories for the ResolutionTool component to improve component documentation and testability.
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-12-25.at.4.43.47.PM.mov