Packages: Fix published * workspace dependencies #68240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flaky tests detected in 748bde8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12596055102
|
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
|
It looks like I would be happy to cherry-pick it to |
gziolo
added
[Type] Bug
gziolo
approved these changes
Dec 23, 2024
sirreal
force-pushed
the
fix/lerna-workspace-package-version-replacement
branch
from
98e7ad7 to
91703f9
Compare
sirreal
force-pushed
the
fix/lerna-workspace-package-version-replacement
branch
from
3af7512 to
748bde8
Compare
sirreal
requested review from
ellatrix,
adamsilverstein,
talldan,
swissspidy,
ajitbohra,
peterwilsoncc,
ntwb,
nerrad,
ryanwelcher,
draganescu,
adamziel,
kevin940726,
atimmer,
fabiankaegy and
mmtr
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
4 tasks
|
Thank you for handling it. It was invaluable when debugging npm publishing 🙇🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Packages are (sometimes) being published with
*workspace dependencies since #66272. Thenextanddevworkflows are correctly replacing the*versions. The cause is currently unclear, but testing indicates that restoringfile:dependencies may fix the problem.file:dependencies )*dependencies)Why?
Workspace dependencies of published packages should depend on a specific version or version range, never
*. This can cause breakage for consumers as the dependencies may not be correctly updated when updating packages.How?
Try using
file:dependencies for workspace packages like was used before #66272.Testing Instructions
CI passes.