Block popover: fix scrolling over #68075
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +45 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7ed899d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12387804848
|
stokesman
approved these changes
Jan 1, 2025
There was a problem hiding this comment.
I’ve tested this in various browsers on MacOS and Linux and it’s working well although Firefox has an issue. This also fixes #63260 from my testing and doesn’t regress #45420.
The issue in Firefox is that for some reason the scrolling halts once the block toolbar is no longer under the pointer. It won’t respond again until either you move the pointer or after a substantial pause without initiating another wheel event. Maybe this could be a Firefox bug. Although curiously, I couldn’t reproduce it with the in-between inserter.
I stumbled on a workaround for the Firefox issue by making the wheel event listener not passive. I think it might be worth doing that so this fix is more complete.
The changes makes sense to me so ✅ despite the Firefox issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Scrolling the content when the pointer is over the block popover stopped working.
It seems to be caused by:
BlockPopovercomponent public #61529 (ref no longer passed)Why?
How?
Testing Instructions
Hover over the block toolbar and scroll.
Testing Instructions for Keyboard
Screenshots or screencast