Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A11y: Add script-module #65101
A11y: Add script-module #65101
Changes from 14 commits
3c6a538
7dd871b
cc3e85e
ef29e81
a138eb8
7e0e75b
89745a6
b8b2c42
b76dd7f
22d76aa
03bdb31
41d105d
90d7d10
f3db5bc
d3b54f4
3172472
0282bf5
ca3060a
6552c6b
704a7cc
1b86c49
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 223 in lib/experimental/script-modules.php
GitHub Actions / PHP coding standards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, the same feedback applies as the one shared by @swissspidy in #65123 (comment). I echo that this is really a step backwards from the JS I18N mechanism we implemented all those years ago. However, I hope we can address that with the next planned steps when we replicate the same approach for
@wordpress/i18n
as for the@wordpress/a11y
package.