Remove label from dataview checkbox (#67868)

* Image size fix in lightbox * Revert "Image size fix in lightbox" This reverts commit 63f81c1. * Remove label from dataview checkbox * Feedback changes * Feedback Changes Co-authored-by: karthick-murugan <[email protected]> Co-authored-by: afercia <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: alexstine <[email protected]> Co-authored-by: ntsekouras <[email protected]>
WordPress · Jan 3, 2025 · 89de183 · 89de183
1 parent 3fc25a1
commit 89de183
Showing 1 changed file with 6 additions and 15 deletions.
diff --git a/packages/dataviews/src/components/dataviews-selection-checkbox/index.tsx b/packages/dataviews/src/components/dataviews-selection-checkbox/index.tsx
@@ -1,8 +1,8 @@
 /**
  * WordPress dependencies
  */
-import { __, sprintf } from '@wordpress/i18n';
 import { CheckboxControl } from '@wordpress/components';
+import { __ } from '@wordpress/i18n';
 
 /**
  * Internal dependencies
@@ -29,20 +29,11 @@ export default function DataViewsSelectionCheckbox< Item >( {
 }: DataViewsSelectionCheckboxProps< Item > ) {
 	const id = getItemId( item );
 	const checked = ! disabled && selection.includes( id );
-	let selectionLabel;
-	if ( titleField?.getValue && item ) {
-		// eslint-disable-next-line @wordpress/valid-sprintf
-		selectionLabel = sprintf(
-			checked
-				? /* translators: %s: item title. */ __( 'Deselect item: %s' )
-				: /* translators: %s: item title. */ __( 'Select item: %s' ),
-			titleField.getValue( { item } )
-		);
-	} else {
-		selectionLabel = checked
-			? __( 'Select a new item' )
-			: __( 'Deselect item' );
-	}
+
+	// Fallback label to ensure accessibility
+	const selectionLabel =
+		titleField?.getValue?.( { item } ) || __( '(no title)' );
+
 	return (
 		<CheckboxControl
 			className="dataviews-selection-checkbox"