-
-
Notifications
You must be signed in to change notification settings - Fork 521
[Update] Documentation for sniff WordPress.Files.FilesName #2590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[Update] Documentation for sniff WordPress.Files.FilesName #2590
Conversation
rodrigoprimo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this PR, @jasonkenison! I left some comments with suggestions. Let me know if you have any questions.
|
@jasonkenison, I was just wondering if you'll have a chance to finish this off in the near future. It would be great if this PR could be included in the next WPCS release. If you haven't got time or lost interest, please let us know and we'll see if we can find someone to take over. Thanks! |
|
@jasonkenison, I reacted with 👍 in the last comment of all the conversations where you already addressed my suggestion. When you have a moment, could you please resolve those? I also replied to your question and provided an example. I believe there is still one comment that was not addressed: #2590 (comment) Thanks for your contributions! |
rodrigoprimo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the last comment and for all your work, @jasonkenison! This PR looks good to me.
Related to #1722
Continuing updates from #2492
Closes #2492