Feat/adhoc application flow#716
Merged
goelsonali merged 2 commits intoJun 25, 2026
Merged
Conversation
goelsonali
approved these changes
Jun 25, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
MENTOR_REVIEWINGstatus, bypassing the admin approval stepacceptApplicationdelegates toMentorshipMatchingService.confirmMatch()for AD_HOC cycles, moving directly toMATCHEDconfirmMatchvalidates expected status based on cycle type:MENTOR_REVIEWINGfor AD_HOC,MENTOR_ACCEPTEDfor LONG_TERMsendNewMenteesNotificationat registration time for AD_HOC (mirrorsapproveApplicationbehaviour for LONG_TERM)MentorshipMatchingServiceinjection inMenteeWorkflowServiceto flag cyclic-dependency risk for futurerefactor
Related Issue
#712
Change Type
Screenshots
Pull request checklist
Please check if your PR fulfills the following requirements: