Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR2W Serialization fixes #6

Merged
merged 2 commits into from
Apr 30, 2022

Conversation

nikich340
Copy link
Collaborator

CR2W Serialization fixes

  • Makes every CVariable class SetIsSerialized() on Read(..) and SetValue(..), since these functions assume that CVar contains some data and is not "default" anymore (for SetValue it is checked if new data was really set)
  • It fixes bug when some structures like tags (CBufferVLQInt32:CName) in CEntity and moduleData (SParticleEmitterModuleData) in CParticleEmitter were not marked as "edited" despite having edited children variables (what led to missing these vars in "Show only edited vars" mode in Variable Editor; and in "Dump only edited values" mode in CR2WToText/CR2WToYML)

TODO?:

  • Handle special cases for classes with AddSomeVar() functions, if thery are created and edited from a code.

Copy link
Member

@rfuzzo rfuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. SetIsSerialized()

@rfuzzo rfuzzo merged commit d34bcde into WolvenKit:develop Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants