Custom class fixes and re-enabling of the flow diagram #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WolvenKit would refuse to compile custom class with vanilla enum variables. This is because the compiler was fed an enum class that did not properly extend the vanilla enum class. This is because the vanilla enum calss is in WolvenKit.CR2W and not WolvenKit.CR2W.Types. This is stop gap fix that puts the enum class in the WolvenKit.CR2W namespace however in the future the namespace of the vanilla enums should be corrected.
They were not being included before making it impossible to add custom class chunks(since 7.2)
Enables the flow diagram that was missing since 7.0.
Flow diagram was broken due to ReferenceType not returning the REDType from Reference. This fixes that bug enabling use of the flow diagram in Wkit 7.x.
The flow diagram in WolvenKit is very slow when viewing big phases as it loops over thousands of chunks everytime the user zoom/pans redrawing them over and over. Windows Forms is not a suitable interface for such as system and it needs to be rebuilt with a package more suitable for this application. In the meantime, I have tried to improve performance by not drawing the connections when the user is panning but results are still not that great.
Redoes the fix by commenting in old function rather than editing existing one which breaks chunk editing.
The previous version of this fix broke vanilla chunk filtering. This revised version corrects that however custom class chunks do not feature filtering and will always appears in the add chunk drop down.
|
Good job! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
Custom class fixes and re-enabling of the flow diagram
Implemented:
Fixed:
I know the flow diagram is slow and probably unusable in big phases but many member of the modding community still find it useful. I have brought it back for them. I hope we can eventually do a proper rewrite of it as these quest were just not meant to be edited in a list. I have also fixed any remaining issues with custom classes so now they can actually be compiled and added with no headache. No more having Wkit 7, 6, 0.3 and W3Edit on your PC just to make a custom classes work.