Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues regarding to searching and packing encoded w3strings. #34

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

0matyesz0
Copy link
Contributor

Pull request template

Implemented:

  • Add extra null checks when searching through the text properties of w3strings data when searching.
  • Generated w3strings are now copied to the correct directory paths.

Issues that were fixed:

At packing settings: Instead of using 'Item1' and 'Item2' to name the checkbox options, we should maybe use something like 'ModCheck' and 'DlcCheck' for easier debugging of these items.

Fix for After loading the game strings, searching for specific strings will result in a NullReferenceException inside frmStringsGuiImporter.cs.
issue ref: WolvenKit#32
Fixed WolvenKit#33 issue so packing and copying strings now works like this:
If the MOD option is selected, the application should copy the files to the PackedModDirectory not the DLC.
@nikich340 nikich340 merged commit ed8b1d8 into WolvenKit:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants