Skip to content

add some primitives tests #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2025
Merged

add some primitives tests #2

merged 2 commits into from
Feb 19, 2025

Conversation

@Kindred-Yi
Copy link

@Kindred-Yi Kindred-Yi commented Feb 3, 2025

No description provided.

schromya
schromya requested changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@schromya schromya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work so far! Do you mind giving a quick description what behavior is supposed to happen in a comment at the top of each of these files? Something like this or this, for example?

Also, can ryou remove all the loops and use Mo's latching fix that he explains here? Thanks!

@schromya schromya merged commit 8ee639d into Wisc-HCI:master Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schromya schromya schromya requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kindred-Yi @schromya