-
Notifications
You must be signed in to change notification settings - Fork 1
fix(server.py): include all reviews in PR context when triggered by review #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
WhiteElephantIsNotARobot
wants to merge
4
commits into
WhiteElephant-abc:main
from
WhiteElephantIsNotARobot:fix-review-context
Closed
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c8a6106
fix(server.py): include all reviews in PR context when triggered by r…
WhiteElephantIsNotARobot a7c5133
fix(server.py): include review comments when triggered by comment
WhiteElephantIsNotARobot 31ae141
恢复 review 中 @ 的处理逻辑
WhiteElephantIsNotARobot 400d4f3
fix(server.py): include review comments in comment trigger
WhiteElephantIsNotARobot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for creating history dictionaries for
reviewandreview_commentis duplicated. The logic for creating areviewdictionary here is also present in lines 652-658. Similarly, the logic forreview_commentadded in this PR is a duplicate of the logic in lines 663-669. This code duplication can make future maintenance harder, as any changes would need to be applied in multiple places.To improve maintainability, consider refactoring this by creating helper functions to build these dictionary objects, thus avoiding repetition.