Add support for Mojang-mapped 1.21.5 servers #379
+255
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # api/pom.xml # pom.xml
Collaborator
|
I am not sure if I see #347 as a needed feature yet because I think you can still use Mojang mappings in parts of your plugin even if the plugin is marked as spigot-mapped for AnvilGUI compatibility. As stated earlier, I'm not convinced that maintaining both Spigot and Mojang mappings (which adds complexity and things that can break) is worth it for AnvilGUI. Besides, if you are on 1.21.5 and want to use Mojang mappings, I would probably recommend using the recently added MenuType API instead of AnvilGUI. |
Author
|
i dont see much complexity here. I have done absolutely same thing for SignGUI about an year ago, which project structure is inspired by AnvilGUI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows this library to work in non-spigot mapped 1.21.5 servers using paper-nms maven plugin.
Mojang-mapped modules is using ca.bkaw.paper-nms dependency, which must be generated using
paper-nms:inittask in each of that modules. This tasks downloads paper dev bundle and creates and installs mojang-mapped server artifact.If server is mojang-mapped and there are no mojang-mapped wrapper for current server version, then spigot-mapped wrapper is used.
Closes #347