Conversation
|
Hi, sorry for very late response! I was very busy due to my current academic commitments. I really appreciate your feedback and contribution. Thank you so much. Below is my new update plan, so stay tuned if you're still interested! |
Wendy-Nam
left a comment
There was a problem hiding this comment.
Hi Peter,
First of all, thank you again for your contribution to the plugin!
I truly appreciate the effort you put into simplifying the setup logic. I intended to test and review your PR shortly after it was submitted, but due to an unexpectedly demanding academic schedule, I couldn’t allocate proper time for it—and I apologize for the long delay.
Before merging, I'd like to make sure the updated behavior works as intended. Would you mind sharing:
Your test cases (e.g., input data or example scripts you used)
The expected output or behavior from those inputs
A brief note on your test environment (Ren'Py version, OS, etc.)
This would really help me validate the PR more efficiently and ensure compatibility with current builds.
Thanks again for your patience, and looking forward to your reply!
Best,
Wendy
I rewrote
generate_lipsync_data.pyfrom scratch. Now it will automatically locate the Rhubarb executable and ask which version do you want to run, thus eliminating the need for the end-user to edit the file. I updatedreadme.mdto reflect these changes.