Skip to content

Simplified setup#7

Open
peter-yanase wants to merge 2 commits intoWendy-Nam:mainfrom
peter-yanase:main
Open

Simplified setup#7
peter-yanase wants to merge 2 commits intoWendy-Nam:mainfrom
peter-yanase:main

Conversation

@peter-yanase
Copy link

I rewrote generate_lipsync_data.py from scratch. Now it will automatically locate the Rhubarb executable and ask which version do you want to run, thus eliminating the need for the end-user to edit the file. I updated readme.md to reflect these changes.

@Wendy-Nam
Copy link
Owner

Hi, sorry for very late response!

I was very busy due to my current academic commitments.
I promise to check the updated fix and merge them shortly.
(at least in 8 days - since i have exams this week)

I really appreciate your feedback and contribution. Thank you so much.

Below is my new update plan, so stay tuned if you're still interested!

#8

Copy link
Owner

@Wendy-Nam Wendy-Nam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Peter,
First of all, thank you again for your contribution to the plugin!

I truly appreciate the effort you put into simplifying the setup logic. I intended to test and review your PR shortly after it was submitted, but due to an unexpectedly demanding academic schedule, I couldn’t allocate proper time for it—and I apologize for the long delay.

Before merging, I'd like to make sure the updated behavior works as intended. Would you mind sharing:

Your test cases (e.g., input data or example scripts you used)

The expected output or behavior from those inputs

A brief note on your test environment (Ren'Py version, OS, etc.)

This would really help me validate the PR more efficiently and ensure compatibility with current builds.
Thanks again for your patience, and looking forward to your reply!

Best,
Wendy

@Wendy-Nam Wendy-Nam added the enhancement New feature or request label May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants