Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scope on refreshAccessToken() #34

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ashish-budhraja
Copy link
Contributor

Without adding scope refreshAccessToken is considering default scope resulting in invalid_scope response from the API

Without adding scope refreshAccessToken is considering default scope resulting in invalid_scope response from the API
@Skullbock
Copy link
Collaborator

Thanks!

@Skullbock Skullbock merged commit 042c074 into Weble:develop Dec 19, 2024
@ashish-budhraja ashish-budhraja deleted the patch-1 branch December 19, 2024 15:26
@tm1000
Copy link
Contributor

tm1000 commented Dec 23, 2024

This broke our workflow because we use offline tokens and we set the scopes in the first online creation of the offline token. The result of changing this as a semver bugfix release meant that when we went to get offline access tokens the scopes were empty (because we do not pass scopes we only define scopes on the initial get of the token) thus suddenly all API calls started failing as it trickled up through our infrastructure because scopes went from. null to []. So Zoho no longer used the default

If Zoho did oauth like any sane individual following the oauth spec this wouldnt be an issue

I'd say in the future be more cautious of changes like this

@tm1000
Copy link
Contributor

tm1000 commented Dec 23, 2024

This is actually a result of: thephpleague/oauth2-client#1030 (comment)

But its all related

@tm1000
Copy link
Contributor

tm1000 commented Dec 23, 2024

Once thephpleague/oauth2-client#1053 is merged this PR itself should be reverted

@Skullbock
Copy link
Collaborator

Skullbock commented Dec 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants