v5 #29
v5 #29
Conversation
| $this->state = $this->provider->getState(); | ||
|
|
||
| return $url; | ||
| } | ||
|
|
||
| /** | ||
| * Get the oAuth2 state variable for security checks |
There was a problem hiding this comment.
I think you should still keep the descriptions. They are helpful to know what the function does.
Removing the return and params is fine because you've typed it anyways
There was a problem hiding this comment.
Hi! Thanks for the suggestion. I usually avoid comments that basically match the method name. Seem reduntant. Will try to keep the ones that make sense.
I'm currently waiting on this v5 to see if it makes senso to give it a complete overhaul instead of some small updates, but not sure i have the time.
Any suggestion for a refactoring / improvement are welcome!
There was a problem hiding this comment.
Ah yes that's how @xrobau works too. That makes sense. Maybe just keep it for stuff that needs an additional explanation.
I like having it for IDE purposes.
Everything else looked fine to me
No description provided.