Use "next" as version on main consistently #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-speedometer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julienw
reviewed
Mar 3, 2025
camillobruni
added
the
trivial change
julienw
approved these changes
Apr 9, 2025
| @@ -13,7 +13,7 @@ | |||
| <section id="instructions" class="visible" data-title="Test Instructions"> | |||
| <a href="./" class="logo"> | |||
| <img srcset="resources/[email protected] 2x" src="resources/logo.png" alt="Speedometer" /> | |||
| <div class="version">3.0</div> | |||
| <div class="version next">next</div> | |||
| </a> | |||
| <div class="section-grid"> | |||
| <h1 class="section-header">Speedometer 3 General Instructions</h1> | |||
There was a problem hiding this comment.
Maybe we can remove the version at all here?
| @@ -12,7 +12,7 @@ | |||
| <section id="about" class="visible" data-title="About"> | |||
| <a href="./" class="logo"> | |||
| <img srcset="resources/[email protected] 2x" src="resources/logo.png" alt="Speedometer" /> | |||
| <div class="version">3.0</div> | |||
| <div class="version next">next</div> | |||
| </a> | |||
| <div class="section-grid"> | |||
| <h1 class="section-header">About Speedometer 3</h1> | |||
There was a problem hiding this comment.
This specific one is still there :-) But maybe we can remove the version completely for this line, what do you think?
rniwa
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's use "next" for the main branch version identifier consistently in all sections.