Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote Runner / PostMessge api #456
Remote Runner / PostMessge api #456
Changes from 66 commits
614d2f5
c1450fb
4bddce7
a478795
a7c6fb0
28354b4
d1cff87
ee81ce3
0da54a0
627376c
6558c87
a5cf90b
09cf75d
25a8071
33c3f52
7d520e3
c10ac0c
482feec
8a91e44
7c2febb
71368c4
76db526
5eadca4
26f3e04
a8bc24e
36b4dd5
47beb33
2e1e00f
a9e386e
75f9c71
2c49e18
1186f4b
de2c065
f7caf32
35beb33
ae76076
9c8178f
b8d2ec7
b8ec788
671998e
4cbb74c
baaebd8
3aaa5e0
a698688
eddd017
ee3ceb4
849fddd
96353b4
f7038ca
3310491
34991de
99c148a
67820e8
28da4e9
147ec2c
4bfff88
7ec1fe7
2ced0b1
ec2b883
7b395c2
2f3c311
64e414d
428ffb0
ebff15a
544fe16
7280741
c073c4d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need an explicit await here? Can't we just return the result of
testRunner.runTest()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, since the RAFTestInvoker has this line:
const result = await this._reportCallback();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when is it happening that window isn't present?
optional nit: use
?.
operatorThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next.js throws an error during the build process.
I did try the
?.
operator, but the current implementation was the only way to make Next.js stop complaining.