-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
News Site Next - Article Ids #447
base: main
Are you sure you want to change the base?
News Site Next - Article Ids #447
Conversation
7b0053f
to
5f7b1f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems sane to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me.
One question though: On my computer it looks like Chrome gets a higher boost than Firefox. Could that be because uuid was quite slower in Chrome? Is it interesting that we measure uuid computation? (maybe it's not interesting if it's not on the hot path for websites)
Thanks
This is an alternate solution for: #426
The reason to keep creating unique ids, is that it'll allow us to potentially opt into a complexity param (#430), which could append content by cloning the sections in the data file. This is only possible, if we don't hard-code list ids in the data file (which was the previous solution).
Here, I am just creating the unique ids once, when the data gets assigned to the app, instead of the currently used version that had issues (#422).
note: feel free to ignore the dist folder - that's just the generated build files
Crossbench - 10 iterations:
this pr
main