Skip to content

wasm2c: Mmap+guard on big-endian won't move memory (fix #2599) #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025

Conversation

shravanrn
Copy link
Collaborator

No description provided.

@shravanrn shravanrn requested review from keithw, sbc100 and SoniEx2 May 17, 2025 02:06
@shravanrn shravanrn force-pushed the w2c-s390x branch 5 times, most recently from 3ee91d7 to e1c6a86 Compare May 17, 2025 09:22
@shravanrn shravanrn marked this pull request as draft May 17, 2025 09:52
@shravanrn shravanrn force-pushed the w2c-s390x branch 2 times, most recently from 8f4d9a4 to 7f748a8 Compare May 17, 2025 12:44
@shravanrn shravanrn marked this pull request as ready for review May 17, 2025 13:19
@shravanrn
Copy link
Collaborator Author

Sorry, it took a few iterations to get all the tests passing. Looks like things are working now.

@shravanrn
Copy link
Collaborator Author

@sbc100 @keithw any chance one of you could review this pr?

@shravanrn shravanrn merged commit f976380 into WebAssembly:main Jun 12, 2025
18 checks passed
@shravanrn shravanrn deleted the w2c-s390x branch June 12, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants