wasm2c: Alter how segments are loaded #2555
Conversation
squk
force-pushed
the
fix/data_segments
branch
2 times, most recently
from
6d71aff to
8e29f65
Compare
squk
changed the title
| for (int i = 0; i < sizeof(active_data_segment_data_ptrs) / sizeof(active_data_segment_data_ptrs[0]); i++) { | ||
|
|
||
| LOAD_DATA(instance->w2c_memory, active_data_segment_offsets[i], active_data_segment_data_ptrs[i], active_data_segment_sizes[i]); | ||
| } |
There was a problem hiding this comment.
Do you know why the compiler was using more memory in the old form? Is it because of inlining somehow?
That amount of static data here is the same right? Does the program you are having trouble with contains a huge about of segments?
|
If possible, if you have a simple benchmark that you are using measure compile time for a wasm module with lots of segment data, that would be great to include in the benchmarks folder as well. |
We tracked this down offline to the use of |
This reduces the number of usages of the
LOAD_DATAmacro from the number of segments to one. For large binaries, this greatly reduces the amount of memory required to compile the library