Skip to content

[Custom Descriptors][SharedEverything] Handle shared descriptors in AbstractTypeRefining #8010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

[Custom Descriptors][SharedEverything] Handle shared descriptors in AbstractTypeRefining #8010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/passes/AbstractTypeRefining.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,8 @@ struct AbstractTypeRefining : public Pass {
auto subDescriptor = *optimized;

Builder builder(*getModule());
if (curr->type.isExact() || subDescriptor == HeapTypes::none) {
if (curr->type.isExact() ||
subDescriptor.isMaybeShared(HeapType::none)) {
// This is exact, so we can ignore subtypes, or there is no subtype to
// optimize to. In this case it must trap.
replaceCurrent(builder.makeSequence(builder.makeDrop(curr->ref),
Expand Down
55 changes: 55 additions & 0 deletions test/lit/passes/abstract-type-refining-desc.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1189,3 +1189,58 @@
)
)

;; Shared abstract described types.
(module
(rec
(type $A (sub (shared (descriptor $B (struct)))))
(type $B (sub (shared (describes $A (descriptor $C (struct))))))
(type $C (sub (shared (describes $B (struct)))))
)

;; YESTNH: (rec
;; YESTNH-NEXT: (type $0 (func (param (ref (shared none))) (result (ref (shared none)))))

;; YESTNH: (type $1 (func (param (ref (shared none))) (result (ref (shared none)))))

;; YESTNH: (func $A (type $0) (param $x (ref (shared none))) (result (ref (shared none)))
;; YESTNH-NEXT: (drop
;; YESTNH-NEXT: (local.get $x)
;; YESTNH-NEXT: )
;; YESTNH-NEXT: (unreachable)
;; YESTNH-NEXT: )
;; NO_TNH: (rec
;; NO_TNH-NEXT: (type $0 (func (param (ref (shared none))) (result (ref (shared none)))))

;; NO_TNH: (type $1 (func (param (ref (shared none))) (result (ref (shared none)))))

;; NO_TNH: (func $A (type $0) (param $x (ref (shared none))) (result (ref (shared none)))
;; NO_TNH-NEXT: (drop
;; NO_TNH-NEXT: (local.get $x)
;; NO_TNH-NEXT: )
;; NO_TNH-NEXT: (unreachable)
;; NO_TNH-NEXT: )
(func $A (param $x (ref $A)) (result (ref $B))
(ref.get_desc $A
(local.get $x)
)
)

;; YESTNH: (func $B (type $1) (param $x (ref (shared none))) (result (ref (shared none)))
;; YESTNH-NEXT: (drop
;; YESTNH-NEXT: (local.get $x)
;; YESTNH-NEXT: )
;; YESTNH-NEXT: (unreachable)
;; YESTNH-NEXT: )
;; NO_TNH: (func $B (type $1) (param $x (ref (shared none))) (result (ref (shared none)))
;; NO_TNH-NEXT: (drop
;; NO_TNH-NEXT: (local.get $x)
;; NO_TNH-NEXT: )
;; NO_TNH-NEXT: (unreachable)
;; NO_TNH-NEXT: )
(func $B (param $x (ref $B)) (result (ref $C))
(ref.get_desc $B
(local.get $x)
)
)
)

Loading