feat: add get_pool_stats with optional odds calculation (#418)#471
Merged
Yunusabdul38 merged 2 commits intoWeb3Novalabs:mainfrom Mar 27, 2026
Merged
Conversation
…#418) - Add PoolStats struct with comprehensive pool statistics - Implement get_pool_stats(pool_id, include_odds) function - Optional odds calculation to optimize performance for large pools - Odds represented as fixed-point numbers with 4 decimal precision (e.g., 7500 = 0.75) - When include_odds=false, returns None to skip expensive calculation - When pool has no stakes, odds is None even if include_odds=true Implementation details: - Avoids floating point arithmetic by using integer math with 10_000 multiplier - Checks overflow in odds calculation - Iterates through all outcomes only when include_odds=true and total_stake>0 Tests added: - test_get_pool_stats_without_odds: Verify basic stats without odds calculation - test_get_pool_stats_with_odds: Verify odds are calculated correctly with 4 decimals - test_get_pool_stats_empty_pool: Handle pools with no predictions - test_get_pool_stats_resolved_pool: Verify stats work for resolved pools Fixes Web3Novalabs#418
|
Someone is attempting to deploy a commit to the shola's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@ayomideadeniran Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation details:
Tests added:
Fixes #418