Implement buy_ticket storage updates#252
Open
Utilitycoder wants to merge 1 commit intoWeb3Novalabs:mainfrom
Open
Implement buy_ticket storage updates#252Utilitycoder wants to merge 1 commit intoWeb3Novalabs:mainfrom
Utilitycoder wants to merge 1 commit intoWeb3Novalabs:mainfrom
Conversation
|
@Utilitycoder Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements storage updates for the
buy_ticketfunction as specified in issue #198. It addsEventMetricsto track ticket sales and ensuresUserTicketis correctly recorded for buyers.Changes
EventMetricsstruct andEventMetrics(u64)storage key.get_event_metricsandis_ticket_buyertoCrowdfundingTraitfor better transparency and testing.buy_ticketto incrementtickets_soldinEventMetricsand implemented the new getters.buy_ticket_test.rsto verify that metrics are updated and user tickets are recorded.Verification
cargo build --target wasm32-unknown-unknown --releasesucceeded.cargo test buy_ticket_testpassed all 13 tests.Closes #198