feat: add event fee treasury variant#249
Merged
Akshola00 merged 5 commits intoWeb3Novalabs:mainfrom Mar 27, 2026
Merged
Conversation
Contributor
|
@JTKaduma ci is failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
This PR adds global event-fee treasury tracking for ticket purchases while preserving the existing per-pool fee split.
When a ticket is bought, the contract now continues to:
and also:
EventFeeTreasuryfor centralized event-fee withdrawals/reportingWhat Changed
StorageKey::EventFeeTreasuryusage inbuy_ticketto track aggregate event fees across ticket purchases.TicketTypedefault handling by derivingDefaultand markingStandardas the default variant.pool_createdevent plumbing to pass a singledetailstuple payload instead of multiple discrete parameters.second_crowdfundingtest-only interfaces behind#[cfg(test)]so they do not leak into non-test builds.EventFeeTreasuryis updated correctly across purchasesWhy
This gives the contract a dedicated aggregate treasury for event fees, which makes fee accounting and withdrawals more straightforward without removing the existing per-pool revenue tracking.
Testing
cargo test -q230 passed; 0 failedCloses #182