Implement buy_ticket event state validation#236
Open
Meshmulla wants to merge 2 commits intoWeb3Novalabs:mainfrom
Open
Implement buy_ticket event state validation#236Meshmulla wants to merge 2 commits intoWeb3Novalabs:mainfrom
Meshmulla wants to merge 2 commits intoWeb3Novalabs:mainfrom
Conversation
|
@Meshmulla Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@Meshmulla pls resolve conflicts |
Contributor
|
@Meshmulla update on this |
Contributor
Author
Resolved chief |
Contributor
|
@Meshmulla checks are falling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #194
This PR adds validation to the buy_ticket flow to ensure tickets can only be purchased for valid and active events.
Changes Included:
Validates event existence (EventNotFound)
Ensures event is active before purchase
Checks event deadline to prevent purchases for expired events (EventExpired)
Added unit tests covering failure cases