panel: show new toplevels as inactive by default #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the newly created toplevel is the active one, we will get notified explicitly (via the "state" event). However, if a toplevel is opened in the "background", no event will be sent, and we should not show it as active.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that currently, the panel's window list implementation assumes that a newly opened toplevel is always "active". If this is not true (i.e. a toplevel opens, but is not focused, e.g. using the option from WayfireWM/wayfire#2627), then the panel will display two active toplevels:
This PR fixes it by setting the state to inactive by default until a "state" event is received. This results in correctly only one toplevel displayed as active: