feat: support cursor-shape-v1 protocol #2852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akliuxingyuan
force-pushed
the
cursor-shape-v1
branch
from
9b5ee72 to
f50ca25
Compare
ammen99
requested changes
Sep 29, 2025
src/core/core.cpp
Outdated
| } | ||
|
|
||
| protocols.cursor_shape_manager = wlr_cursor_shape_manager_v1_create(display, 1); | ||
| cursor_shape_set_request.set_callback([&] (void *data) |
There was a problem hiding this comment.
We seem to be using a lot of seat->priv->cursor->... fields here. Maybe we should move the whole thing to a method in https://github.com/WayfireWM/wayfire/blob/master/src/core/seat/cursor.hpp#L11
In fact we already have something similar here https://github.com/WayfireWM/wayfire/blob/master/src/core/seat/cursor.hpp#L26, so we could even refactor the checks to be shared (a private method cursor_t::can_client_set_cursor() which does the checks).
akliuxingyuan
force-pushed
the
cursor-shape-v1
branch
from
f50ca25 to
29cff64
Compare
|
please take a look at the codestyle, the CI contains a patch you can apply. |
|
code style fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.